pepijnve commented on PR #18183: URL: https://github.com/apache/datafusion/pull/18183#issuecomment-3559976404
@rluvaton in an attempt to speed things up I've bundled everything I wanted to suggest in a PR instead at https://github.com/rluvaton/datafusion/pull/6 The intent here is to split the scalar value key/value maps and the usage of this for case a bit further and then use consistent terminology and naming across all the types and comments. All the case specific bits are now consolidated in the `impl TryFrom<&CaseBody> for LiteralLookupTable` and `LiteralLookupTable` is a somewhat vectorized hash table of `ScalarValue` to `ScalarValue`. As I said before, I'm not a committer and I'm only trying to express my point of view wrt this code. I'll leave it up to you to decide if you want to integrate these suggestions or not. In terms of the implementation itself nothing has changed (or at least not intentionally). That was already fine as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
