2010YOUY01 commented on code in PR #18837:
URL: https://github.com/apache/datafusion/pull/18837#discussion_r2548325745
##########
datafusion/functions-aggregate/src/percentile_cont.rs:
##########
@@ -760,3 +914,80 @@ fn calculate_percentile<T: ArrowNumericType>(
}
}
}
+
+#[cfg(test)]
+mod tests {
Review Comment:
> We should remove the unit tests if they duplicate the sqllogictests
+1 unless there are something can't be covered by slt tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
