BlakeOrth commented on code in PR #18855:
URL: https://github.com/apache/datafusion/pull/18855#discussion_r2550795060
##########
datafusion/core/tests/datasource/object_store_access.rs:
##########
@@ -237,8 +233,7 @@ async fn query_partitioned_csv_file() {
+---------+-------+-------+---+----+-----+
------- Object Store Request Summary -------
RequestCountingObjectStore()
- Total Requests: 2
- - LIST prefix=data
+ Total Requests: 1
Review Comment:
Yes, I think that's a good test case, and obviously any tests have more or
less been ignored thus far. The only tests I actually focused on initially were
these tests since they both show (and helped me validate) this code was
actually performing internal caching as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
