alchemist51 commented on code in PR #18855: URL: https://github.com/apache/datafusion/pull/18855#discussion_r2560294003
########## datafusion/execution/src/cache/cache_manager.rs: ########## @@ -42,8 +47,18 @@ pub type FileStatisticsCache = /// especially when done over remote object stores. /// /// See [`crate::runtime_env::RuntimeEnv`] for more details -pub type ListFilesCache = - Arc<dyn CacheAccessor<Path, Arc<Vec<ObjectMeta>>, Extra = ObjectMeta>>; +pub trait ListFilesCache: Review Comment: A little bit side topic. @alamb was looking into other caches, didn't understand why `DefaultFileStatisticsCache` isn't memory bound yet. Do we want to do it incrementally? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
