timsaucer commented on code in PR #18672:
URL: https://github.com/apache/datafusion/pull/18672#discussion_r2553155986
##########
datafusion-examples/examples/ffi/ffi_module_loader/src/main.rs:
##########
@@ -49,13 +49,13 @@ async fn main() -> Result<()> {
))?();
// In order to access the table provider within this executable, we need to
- // turn it into a `ForeignTableProvider`.
- let foreign_table_provider: ForeignTableProvider =
(&ffi_table_provider).into();
+ // turn it into a `TableProvider`.
Review Comment:
This will be a breaking change from 51 -> 52. Actually this is the first of
a series of 9 total PRs for a massive overhaul of the FFI work. I've updated
the description in https://github.com/apache/datafusion/issues/18671 to
describe the steps. When I first put up the branch, the diff was 6k lines so
I've broken it into more manageable chunks.
While this is disruptive from 51->52 I think the benefits of the new code
are massive and unblocking features both my team and [lance
#5144](https://github.com/lance-format/lance/issues/5144) have discovered. Also
the full code will unlock serialization and deserialization of plans over the
FFI boundary using extension codecs. I think that will be impactful for the
distributed work underway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
