2010YOUY01 commented on issue #18881:
URL: https://github.com/apache/datafusion/issues/18881#issuecomment-3568727359
> > If there is a good way to deal with the mentioned feature flag issue, I
think we should add this lint rule.
>
> It would look something like this:
>
> fn get_metadata<'a>(
> &'a mut self,
> #[cfg_attr(not(feature = "parquet_encryption"),
expect(unused_variables))]
> options: Option<&'a ArrowReaderOptions>,
> ) -> BoxFuture<'a, parquet::errors::Result<Arc<ParquetMetaData>>> {
> Doable, but a little verbose.
I think this marker describes the arg quite precisely: 'this arg is only
used in `parquet_encryption`' feature.
So I'm +1 for this lint. Maybe we should add comment like the above
explanation, to deal with the verbosity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
