xitep commented on issue #2065: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2065#issuecomment-3574557880
ok, thanks for your feedback @iffyio. i'll prepare a PR for that. even with the shortcuts we discussed, having `sqlparser-rs` publish the comments still seems a better idea to me than leaving clients completely without or with writing their own parser (essentially processing the sql source once again.) btw: i'm more inclined to publish the comments' content as `&str` (as opposed to an owned `String`) with the lifetime bound to the parsed sql string. would you agree before i set off with the work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
