xitep commented on issue #2065: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2065#issuecomment-3575177497
alright, many thanks for the hint, @iffyio ! that sounds to me like at this point i should go with (owned) `String`s. Eventually it'd be reworked to a more efficient presentation. I believe it would be simply more consistent with the current crate API. (btw: in my proof-of-concept, i keep comments internally as `Comment<Range<u32>>` with the range representing the start and endpoint in the parsed SQL. only when handing them out to the user i turn them into a `Comment<&str>` ... hence, the API proposal above.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
