rluvaton commented on PR #18183: URL: https://github.com/apache/datafusion/pull/18183#issuecomment-3580444990
> > can you please rereview @pepijnve > > Nice side effect is that the 'bytes_like' code got much simpler 👍 Is it worth doing the same thing for the primitive and boolean implementations? what do you mean by doing the same? I only moved the match for datatype inside the `bytes_like`. what would I need to move for boolean implementation? it's a single type. and I can't move the type for primitive as the hash key is different (e.g. i8, i32, float bits, etc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
