ntjohnson1 commented on code in PR #18918:
URL: https://github.com/apache/datafusion/pull/18918#discussion_r2566215384
##########
datafusion/ffi/src/session_config.rs:
##########
@@ -15,17 +15,13 @@
// specific language governing permissions and limitations
// under the License.
-use abi_stable::{
- std_types::{RHashMap, RString},
- StableAbi,
-};
-use datafusion::{config::ConfigOptions, error::Result};
-use datafusion::{error::DataFusionError, prelude::SessionConfig};
-use std::sync::Arc;
-use std::{
- collections::HashMap,
- ffi::{c_char, c_void, CString},
-};
+use std::collections::HashMap;
+use std::ffi::c_void;
+
+use abi_stable::std_types::{RHashMap, RString};
+use abi_stable::StableAbi;
+use datafusion_common::error::{DataFusionError, Result};
+use datafusion_execution::config::SessionConfig;
/// A stable struct for sharing [`SessionConfig`] across FFI boundaries.
/// Instead of attempting to expose the entire SessionConfig interface, we
Review Comment:
Hmm this is no longer storing ConfigOptions as private data. So this doc
string doesn't seem to be totally correct. It still uses config options to go
from FFI_ to SessionConfig but doesn't convert to config options to get into FFI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
