wForget commented on code in PR #2828:
URL: https://github.com/apache/datafusion-comet/pull/2828#discussion_r2566873077
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometNativeWriteExec.scala:
##########
@@ -86,27 +154,149 @@ case class CometNativeWriteExec(nativeOp: Operator,
child: SparkPlan, outputPath
// Capture metadata before the transformation
val numPartitions = childRDD.getNumPartitions
val numOutputCols = child.output.length
+ val broadcastedCommitter = committer.map(c => sparkContext.broadcast(c))
Review Comment:
The committer should not use broadcast, because broadcast value is usually
immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
