wForget commented on code in PR #2828:
URL: https://github.com/apache/datafusion-comet/pull/2828#discussion_r2566948458
##########
native/core/src/execution/operators/parquet_writer.rs:
##########
@@ -197,11 +224,18 @@ impl ExecutionPlan for ParquetWriterExec {
Arc::clone(&input_schema)
};
+ // Determine the write path (work_dir for temp files, or output_path
for direct write)
Review Comment:
Do we still need to keep the behavior of writing directly to `output_path`?
This seems risky, because we don’t have any failure cleanup in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
