Jefffrey commented on code in PR #18950:
URL: https://github.com/apache/datafusion/pull/18950#discussion_r2570230871
##########
datafusion/functions/src/encoding/inner.rs:
##########
@@ -553,3 +567,29 @@ fn decode(args: &[ColumnarValue]) -> Result<ColumnarValue>
{
}?;
decode_process(expression, encoding)
}
+
+#[cfg(test)]
+mod tests {
+ #[test]
+ fn test_encode_fsb() {
Review Comment:
The commit you linked had extra changes this PR was initially missing (to
the signature and return type code) which @martin-g also identified; my
intention with commenting only about including SLTs was because this would have
end-to-end coverage of the function and a SLT test would have caught this gap
during testing instead of at PR review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
