Jefffrey commented on code in PR #18950:
URL: https://github.com/apache/datafusion/pull/18950#discussion_r2566539002
##########
datafusion/functions/src/encoding/inner.rs:
##########
@@ -553,3 +567,29 @@ fn decode(args: &[ColumnarValue]) -> Result<ColumnarValue>
{
}?;
decode_process(expression, encoding)
}
+
+#[cfg(test)]
+mod tests {
+ #[test]
+ fn test_encode_fsb() {
Review Comment:
In this case it is very necessary, because it reveals that the signature of
the function doesn't actually accept FixedSizeBinary arrays, something calling
the function directly in code like this wouldn't make obvious.
While SLTs can be harder to write, we prefer it because they are less
verbose, and they can test functions with a more stable interface (SQL) rather
than their internal APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
