martin-g commented on code in PR #19065:
URL: https://github.com/apache/datafusion/pull/19065#discussion_r2585284601
##########
datafusion/spark/src/function/math/width_bucket.rs:
##########
@@ -53,8 +59,48 @@ impl Default for SparkWidthBucket {
impl SparkWidthBucket {
pub fn new() -> Self {
+ let numeric = Coercion::new_implicit(
+ TypeSignatureClass::Native(logical_float64()),
+ vec![
+ TypeSignatureClass::Integer,
+ TypeSignatureClass::Float,
+ TypeSignatureClass::Decimal,
Review Comment:
One question: The old code uses `is_signed_numeric()` but the new one also
accepts unsigned types too. Is this OK ?
https://github.com/apache/datafusion/pull/19065/files#diff-17406854dfab29f23a249c75743d8a25cc18e445b3b2170255c8371be2573593L99-L101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
