Jefffrey commented on code in PR #19065:
URL: https://github.com/apache/datafusion/pull/19065#discussion_r2585312079
##########
datafusion/spark/src/function/math/width_bucket.rs:
##########
@@ -53,8 +59,48 @@ impl Default for SparkWidthBucket {
impl SparkWidthBucket {
pub fn new() -> Self {
+ let numeric = Coercion::new_implicit(
+ TypeSignatureClass::Native(logical_float64()),
+ vec![
+ TypeSignatureClass::Integer,
+ TypeSignatureClass::Float,
+ TypeSignatureClass::Decimal,
Review Comment:
Personally I think this is fine; I assumed the old signature was signed
numerics only since Spark (Java) doesn't support unsigned types. I don't
particularly see an issue with widening the signature if its more ergonomic for
us when writing this code.
Perhaps @comphead can weigh in on whether accepting unsigned ints for Spark
functions matters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
