Copilot commented on code in PR #19073:
URL: https://github.com/apache/datafusion/pull/19073#discussion_r2586306944
##########
datafusion/sqllogictest/test_files/encrypted_parquet.slt:
##########
@@ -85,5 +85,10 @@ float_field float
)
STORED AS PARQUET LOCATION 'test_files/scratch/encrypted_parquet/'
-query error DataFusion error: Parquet error: Parquet error: Parquet file has
an encrypted footer but decryption properties were not provided
+query RR rowsort
SELECT * FROM parquet_table
+----
+-1 -1
+1 2
+3 4
+5 6
Review Comment:
This change converts a test that previously expected an error (`query error
DataFusion error: Parquet error: Parquet file has an encrypted footer but
decryption properties were not provided`) into one that expects successful
results. This is a significant behavioral change that goes beyond just marking
the query as `rowsort`. The PR description states "Marked an encrypted parquet
test query as `rowsort`" but doesn't explain why the query now succeeds instead
of failing. Please verify this is intentional and update the PR description to
explain why the encrypted parquet query now returns results instead of an error.
```suggestion
query RR
SELECT * FROM parquet_table
----
query error DataFusion error: Parquet error: Parquet file has an encrypted
footer but decryption properties were not provided
```
##########
datafusion/sqllogictest/test_files/clickbench_extended.slt:
##########
@@ -45,8 +45,8 @@ SELECT "BrowserCountry", COUNT(DISTINCT "SocialNetwork"),
COUNT(DISTINCT "HitCo
query IIIRRRR
SELECT "SocialSourceNetworkID", "RegionID", COUNT(*), AVG("Age"),
AVG("ParamPrice"), STDDEV("ParamPrice") as s, VAR("ParamPrice") FROM hits
GROUP BY "SocialSourceNetworkID", "RegionID" HAVING s IS NOT NULL ORDER BY s
DESC LIMIT 10;
----
-0 839 6 0 0 0 0
0 197 2 0 0 0 0
+0 839 6 0 0 0 0
Review Comment:
The result order has changed between the two rows with identical `s` values
(both 0). Since these rows have the same value for the `ORDER BY` column, their
relative order is non-deterministic. Consider adding `rowsort` to this query to
avoid test flakiness, similar to what was done for the encrypted_parquet test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
