zhuqi-lucas commented on code in PR #19042:
URL: https://github.com/apache/datafusion/pull/19042#discussion_r2587983162
##########
benchmarks/src/clickbench.rs:
##########
@@ -136,10 +158,24 @@ impl RunOpt {
parquet_options.pushdown_filters = true;
parquet_options.reorder_filters = true;
}
+
+ if self.sorted_by.is_some() {
+ // We should compare the dynamic topk optimization when data
is sorted, so we make the
+ // assumption that filter pushdown is also enabled in this
case.
+ parquet_options.pushdown_filters = true;
+ parquet_options.reorder_filters = true;
+ }
}
let rt_builder = self.common.runtime_env_builder()?;
let ctx = SessionContext::new_with_config_rt(config,
rt_builder.build_arc()?);
+
+ // Debug: print actual target_partitions being used
Review Comment:
Yes, i will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
