zhuqi-lucas commented on PR #19042:
URL: https://github.com/apache/datafusion/pull/19042#issuecomment-3615963568
> Thank you @zhuqi-lucas @2010YOUY01 and @xudong963 -- this is really nice 👌
>
> I tested it locally like
>
> ```shell
> ./bench.sh data data_sorted_clickbench
> ```
>
> And then
>
> ```shell
> ./bench.sh run data_sorted_clickbench
> ```
>
> It seems to have worked great
>
> ```
> ⚠️ Overriding target_partitions=1 to preserve sort order
> ⚠️ (Because we want to get the pure performance benefit of sorted data to
compare)
> 📊 Session config target_partitions: 1
> Registering table with sort order: EventTime ASC
> Executing: CREATE EXTERNAL TABLE hits STORED AS PARQUET LOCATION
'/Users/andrewlamb/Software/datafusion2/benchmarks/data/hits_0_sorted.parquet'
WITH ORDER ("EventTime" ASC)
> Q0: -- Must set for ClickBench hits_partitioned dataset. See
https://github.com/apache/datafusion/issues/16591
> -- set datafusion.execution.parquet.binary_as_string = true
> SELECT * FROM hits ORDER BY "EventTime" DESC limit 10;
>
> Query 0 iteration 0 took 228.9 ms and returned 10 rows
> Query 0 iteration 1 took 178.1 ms and returned 10 rows
> Query 0 iteration 2 took 178.5 ms and returned 10 rows
> Query 0 iteration 3 took 177.8 ms and returned 10 rows
> Query 0 iteration 4 took 179.1 ms and returned 10 rows
> Query 0 avg time: 188.49 ms
> + set +x
> Done
> ```
>
> i have a few suggestions but nothing that is necessary in my opinion.
Thank you @alamb for review, addressed the comments in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
