Copilot commented on code in PR #19181:
URL: https://github.com/apache/datafusion/pull/19181#discussion_r2596454067
##########
datafusion/spark/src/function/string/luhn_check.rs:
##########
@@ -15,16 +15,14 @@
// specific language governing permissions and limitations
// under the License.
-use std::{any::Any, sync::Arc};
-
use arrow::array::{Array, AsArray, BooleanArray};
-use arrow::datatypes::DataType;
+use arrow::datatypes::{DataType, Field, FieldRef};
use arrow::datatypes::DataType::Boolean;
use datafusion_common::utils::take_function_args;
use datafusion_common::{exec_err, Result, ScalarValue};
use datafusion_expr::{
- ColumnarValue, ScalarFunctionArgs, ScalarUDFImpl, Signature, TypeSignature,
- Volatility,
+ ColumnarValue, ReturnFieldArgs, ScalarFunctionArgs, ScalarUDFImpl,
Signature,
+ TypeSignature, Volatility,
};
Review Comment:
Missing required imports for `Arc` and `Any`. The code uses `Arc::new()` on
line 75 and `&dyn Any` on line 57, but `std::sync::Arc` and `std::any::Any` are
not imported. These imports were removed but are still needed by the code.
```suggestion
use std::sync::Arc;
use std::any::Any;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
