ethan-tyler commented on code in PR #19142: URL: https://github.com/apache/datafusion/pull/19142#discussion_r2603598673
########## datafusion/core/tests/custom_sources_cases/dml_planning.rs: ########## @@ -0,0 +1,296 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Tests for DELETE and UPDATE planning to verify filter and assignment extraction. + +use std::any::Any; Review Comment: Good timing - I had this sitting in a separate branch to keep the API PR small. Merged it in now. Adds delete_from() and update() to MemTable as a working example. Two new SLT files: - MemTable.delete_from() / MemTable.update() - reference implementation - dml_delete.slt (202 lines, 10 tests) - DELETE operations - dml_update.slt (259 lines, 12 tests) - UPDATE operations Covers the basics plus NULL predicate handling (important for SQL correctness). The existing delete.slt/update.slt now expect success since MemTable supports these operations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
