adriangb commented on code in PR #18832:
URL: https://github.com/apache/datafusion/pull/18832#discussion_r2612258575
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -138,9 +142,20 @@ fn instantiate_static_filter(
in_array: ArrayRef,
) -> Result<Arc<dyn StaticFilter + Send + Sync>> {
match in_array.data_type() {
+ // Integer primitive types
+ DataType::Int8 => Ok(Arc::new(Int8StaticFilter::try_new(&in_array)?)),
+ DataType::Int16 =>
Ok(Arc::new(Int16StaticFilter::try_new(&in_array)?)),
DataType::Int32 =>
Ok(Arc::new(Int32StaticFilter::try_new(&in_array)?)),
+ DataType::Int64 =>
Ok(Arc::new(Int64StaticFilter::try_new(&in_array)?)),
+ DataType::UInt8 =>
Ok(Arc::new(UInt8StaticFilter::try_new(&in_array)?)),
+ DataType::UInt16 =>
Ok(Arc::new(UInt16StaticFilter::try_new(&in_array)?)),
+ DataType::UInt32 =>
Ok(Arc::new(UInt32StaticFilter::try_new(&in_array)?)),
+ DataType::UInt64 =>
Ok(Arc::new(UInt64StaticFilter::try_new(&in_array)?)),
+ // Float primitive types (use ordered wrappers for Hash/Eq)
+ DataType::Float32 =>
Ok(Arc::new(Float32StaticFilter::try_new(&in_array)?)),
+ DataType::Float64 =>
Ok(Arc::new(Float64StaticFilter::try_new(&in_array)?)),
Review Comment:
No but I don't think that was optimized before and there's less opportunity
to optimize because of the copy price. I'm going to leave that for
https://github.com/apache/datafusion/issues/19241 where there's already a lot
of great ideas if that's okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
