eyalleshem commented on issue #2036: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2036#issuecomment-3649902151
@xitep - Thanks for sharing, these are very interesting results! I think in real-world scenarios many identifiers won't be keywords. Another approach worth exploring could be a case-insensitive trie - that would likely identify non-keywords after just 2-3 character comparisons, and keywords with ~2n comparisons (where n is the word length). I'm going to keep my branch focused on reducing allocations for now, but this seems worth a separate issue/PR to the main branch if you're interested in pursuing it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
