tobixdev commented on code in PR #18552:
URL: https://github.com/apache/datafusion/pull/18552#discussion_r2617254052
##########
datafusion/common/src/types/logical.rs:
##########
@@ -32,7 +34,7 @@ pub enum TypeSignature<'a> {
/// The `name` should contain the same value as 'ARROW:extension:name'.
Extension {
name: &'a str,
- parameters: &'a [TypeParameter<'a>],
+ parameters: Vec<TypeParameter<'a>>,
Review Comment:
I was wrangling with the lifetime 'a as it's both used for the parameter and
the slice. We can change that once we clean-up the PR if we find a better
solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
