tobixdev commented on code in PR #18552:
URL: https://github.com/apache/datafusion/pull/18552#discussion_r2617266976
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -6085,21 +6085,21 @@ async fn test_alias() -> Result<()> {
Ok(())
}
-#[tokio::test]
-async fn test_alias_with_metadata() -> Result<()> {
- let mut metadata = HashMap::new();
- metadata.insert(String::from("k"), String::from("v"));
- let metadata = FieldMetadata::from(metadata);
- let df = create_test_table("test")
- .await?
- .select(vec![col("a").alias_with_metadata("b", Some(metadata))])?
- .alias("table_alias")?;
- let df = df.select(vec![col("table_alias.b")])?;
- let schema = df.schema();
- let metadata = schema.field(0).metadata();
- assert_eq!(metadata.get("k"), Some(&String::from("v")));
- Ok(())
-}
+// #[tokio::test]
Review Comment:
These tests rely on the old `MetadataField` and I haven't fixed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
