renato2099 commented on code in PR #19281:
URL: https://github.com/apache/datafusion/pull/19281#discussion_r2617369833
##########
datafusion/ffi/src/plan_properties.rs:
##########
@@ -92,15 +78,8 @@ impl FFI_PlanProperties {
unsafe extern "C" fn output_partitioning_fn_wrapper(
properties: &FFI_PlanProperties,
-) -> FFIResult<RVec<u8>> {
- let codec = DefaultPhysicalExtensionCodec {};
- let partitioning_data = rresult_return!(serialize_partitioning(
- properties.inner().output_partitioning(),
- &codec
- ));
- let output_partitioning = partitioning_data.encode_to_vec();
-
- ROk(output_partitioning.into())
Review Comment:
thank you for noting that @paleolimbot ! that was not obvious to me
##########
datafusion/ffi/src/plan_properties.rs:
##########
@@ -184,38 +158,18 @@ impl TryFrom<FFI_PlanProperties> for PlanProperties {
let ffi_schema = unsafe { (ffi_props.schema)(&ffi_props) };
let schema = (&ffi_schema.0).try_into()?;
- // TODO Extend FFI to get the registry and codex
- let default_ctx = SessionContext::new();
- let task_context = default_ctx.task_ctx();
- let codex = DefaultPhysicalExtensionCodec {};
Review Comment:
just for my own learning, before we were setting a specific `codex` here, do
we need to worry about it? should we be using the one that is coming with from
ffi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
