timsaucer commented on code in PR #19281:
URL: https://github.com/apache/datafusion/pull/19281#discussion_r2635797430
##########
datafusion/ffi/src/plan_properties.rs:
##########
@@ -184,38 +158,18 @@ impl TryFrom<FFI_PlanProperties> for PlanProperties {
let ffi_schema = unsafe { (ffi_props.schema)(&ffi_props) };
let schema = (&ffi_schema.0).try_into()?;
- // TODO Extend FFI to get the registry and codex
- let default_ctx = SessionContext::new();
- let task_context = default_ctx.task_ctx();
- let codex = DefaultPhysicalExtensionCodec {};
Review Comment:
We are no longer using the codec for the physical side. We are now only
using protobuf on the logical side. That's why we're able to remove these parts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
