kumarUjjawal commented on code in PR #19310:
URL: https://github.com/apache/datafusion/pull/19310#discussion_r2617988970
##########
datafusion/ffi/src/expr/distribution.rs:
##########
@@ -29,7 +29,7 @@ use datafusion_expr::statistics::{
#[repr(C)]
#[derive(Debug, StableAbi)]
#[allow(non_camel_case_types)]
-#[expect(clippy::large_enum_variant)]
+#[allow(clippy::large_enum_variant)]
Review Comment:
When I add `#![deny(clippy::allow_attributes)]` in ffi, I get several
unfulfilled expectations, so we’d need to also enable the relevant lints
(`#![warn(non_camel_case_types, clippy::type_complexity,
clippy::disallowed_methods, clippy::large_enum_variant)]`) so the `#[expect]`s
actually fire. Is there any alternative you have in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
