Jefffrey commented on code in PR #19310:
URL: https://github.com/apache/datafusion/pull/19310#discussion_r2621176387
##########
datafusion/ffi/src/expr/distribution.rs:
##########
@@ -29,7 +29,7 @@ use datafusion_expr::statistics::{
#[repr(C)]
#[derive(Debug, StableAbi)]
#[allow(non_camel_case_types)]
-#[expect(clippy::large_enum_variant)]
+#[allow(clippy::large_enum_variant)]
Review Comment:
So from what I've seen, the main problem is that `expect` doesn't play well
with `non_camel_case_types`? I haven't had time to look into it properly, but
we'll definitely want to figure something out for this instead of omitting the
`#![deny(clippy::allow_attributes)]` in ffi entirely. Maybe for this PR we can
exclude ffi until we figure out a proper solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
