kumarUjjawal commented on code in PR #19189:
URL: https://github.com/apache/datafusion/pull/19189#discussion_r2618574992
##########
datafusion/functions/src/string/concat.rs:
##########
@@ -79,7 +81,31 @@ impl ScalarUDFImpl for ConcatFunc {
fn as_any(&self) -> &dyn Any {
self
}
+ fn return_field_from_args(
Review Comment:
@ujjwaltwri we should not be making changes to this file of Datafusion, we
only want the changes in the Spark
[datafusion/spark/src/function/string/concat.rs](). You should revert the
changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
