adriangb commented on code in PR #19064:
URL: https://github.com/apache/datafusion/pull/19064#discussion_r2620058764
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -1094,6 +1096,27 @@ impl ExecutionPlan for RepartitionExec {
Ok(FilterPushdownPropagation::if_all(child_pushdown_result))
}
+ fn try_pushdown_sort(
+ &self,
+ order: &[PhysicalSortExpr],
+ ) -> Result<SortOrderPushdownResult<Arc<dyn ExecutionPlan>>> {
+ // RepartitionExec only maintains input order if preserve_order is set
+ // or if there's only one partition
Review Comment:
Is the single partition case handled?
##########
datafusion/datasource/src/file.rs:
##########
@@ -183,4 +200,19 @@ pub trait FileSource: Send + Sync {
fn schema_adapter_factory(&self) -> Option<Arc<dyn SchemaAdapterFactory>> {
None
}
+
+ /// Set the file ordering information
+ ///
+ /// This allows the file source to know how the files are sorted,
+ /// enabling it to make informed decisions about sort pushdown.
+ ///
+ /// Default implementation returns self (no-op for sources that don't need
ordering info)
+ fn with_file_ordering_info(
+ &self,
+ _ordering: Option<LexOrdering>,
+ ) -> Result<Arc<dyn FileSource>> {
+ // Default: clone self without modification
+ // ParquetSource will override this
+ not_impl_err!("with_file_ordering_info not implemented for this
FileSource")
Review Comment:
The comment doesn't match the implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
