zhuqi-lucas commented on code in PR #19064:
URL: https://github.com/apache/datafusion/pull/19064#discussion_r2621903537
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -1094,6 +1096,27 @@ impl ExecutionPlan for RepartitionExec {
Ok(FilterPushdownPropagation::if_all(child_pushdown_result))
}
+ fn try_pushdown_sort(
+ &self,
+ order: &[PhysicalSortExpr],
+ ) -> Result<SortOrderPushdownResult<Arc<dyn ExecutionPlan>>> {
+ // RepartitionExec only maintains input order if preserve_order is set
+ // or if there's only one partition
Review Comment:
Yes - `maintains_input_order_helper` returns true for single partitions, so
the check passes and sort pushdown works correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
