Jefffrey commented on code in PR #19315:
URL: https://github.com/apache/datafusion/pull/19315#discussion_r2625566448
##########
datafusion/functions/src/math/log.rs:
##########
@@ -289,6 +294,19 @@ impl ScalarUDFImpl for LogFunc {
if num_args != 1 && num_args != 2 {
return plan_err!("Expected log to have 1 or 2 arguments, got
{num_args}");
}
+
+ match arg_types.last().unwrap() {
Review Comment:
```suggestion
// TODO: ScalarValue doesn't support negative scale, remove when it
does
// See: https://github.com/apache/datafusion/issues/19354
match arg_types.last().unwrap() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
