adriangb commented on code in PR #19379:
URL: https://github.com/apache/datafusion/pull/19379#discussion_r2628904316
##########
datafusion/physical-plan/src/joins/hash_join/partitioned_hash_eval.rs:
##########
@@ -87,12 +132,15 @@ impl Hash for HashExpr {
fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
self.on_columns.dyn_hash(state);
self.description.hash(state);
+ self.seeds().hash(state);
}
}
impl PartialEq for HashExpr {
fn eq(&self, other: &Self) -> bool {
- self.on_columns == other.on_columns && self.description ==
other.description
+ self.on_columns == other.on_columns
+ && self.description == other.description
+ && self.seeds() == other.seeds()
Review Comment:
I think there was also a bug lurking here where expressions would
erroneously compare equal even if they had different `RandomState`s. I don't
think it was likely to result in a real bug but let's fix it while were here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
