manuzhang commented on code in PR #2916:
URL: https://github.com/apache/datafusion-comet/pull/2916#discussion_r2629450588
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -755,11 +757,13 @@ macro_rules! cast_decimal_to_int32_up {
.map(|value| match value {
Some(value) => {
let divisor = 10_i128.pow($scale as u32);
- let (truncated, decimal) = (value / divisor, (value %
divisor).abs());
+ let truncated = value / divisor;
let is_overflow = truncated.abs() >
$max_dest_val.into();
+ let fmt_str =
Review Comment:
Nope, `fmt_str` will be out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
