andygrove commented on code in PR #2916:
URL: https://github.com/apache/datafusion-comet/pull/2916#discussion_r2632571707
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -1030,7 +1030,9 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
test("cast between decimals with higher precision than source") {
// cast between Decimal(10, 2) to Decimal(10,4)
- castTest(generateDecimalsPrecision10Scale2(),
DataTypes.createDecimalType(10, 4))
+ castTest(
Review Comment:
@manuzhang I pulled these test changes locally using latest from main branch
and they pass for me, so I'm not sure that these tests reproduce the problem
that the fix is intended to address?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
