pepijnve commented on code in PR #19287:
URL: https://github.com/apache/datafusion/pull/19287#discussion_r2630293948
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -643,6 +678,21 @@ impl GroupedHashAggregateStream {
}
}
+fn find_sort_options(
Review Comment:
Thanks for the reminder. I had forgotten to do that. I moved it over to
`LexOrdering` as `pub fn get_sort_options(&self, expr: &dyn PhysicalExpr) ->
Option<SortOptions>` and adapted the code in `GroupedHashAggregateStream` for
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
