Jefffrey commented on code in PR #19355:
URL: https://github.com/apache/datafusion/pull/19355#discussion_r2633297683


##########
datafusion/sqllogictest/test_files/spark/hash/crc32.slt:
##########
@@ -81,7 +81,7 @@ SELECT crc32(arrow_cast('Spark', 'BinaryView'));
 ----
 1557323817
 
-# Upstream arrow-rs issue: https://github.com/apache/arrow-rs/issues/8841
-# This should succeed after we receive the fix
-query error Arrow error: Compute error: Internal Error: Cannot cast BinaryView 
to BinaryArray of expected type
+query I

Review Comment:
   I think this fix will also close #19290; quickly tested checking this PR 
branch out and trying the test in the issue and it seems to execute successfully



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to