gabotechs commented on code in PR #19379:
URL: https://github.com/apache/datafusion/pull/19379#discussion_r2633981251
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -86,9 +86,11 @@ use
datafusion_physical_expr_common::utils::evaluate_expressions_to_arrays;
use futures::TryStreamExt;
use parking_lot::Mutex;
+use super::partitioned_hash_eval::SeededRandomState;
+
/// Hard-coded seed to ensure hash values from the hash join differ from
`RepartitionExec`, avoiding collisions.
-pub(crate) const HASH_JOIN_SEED: RandomState =
- RandomState::with_seeds('J' as u64, 'O' as u64, 'I' as u64, 'N' as u64);
+pub(crate) const HASH_JOIN_SEED: SeededRandomState =
+ SeededRandomState::with_seeds('J' as u64, 'O' as u64, 'I' as u64, 'N' as
u64);
Review Comment:
👍 I like the fact that having this `SeededRandomState` struct is an explicit
indicator that the underlaying `RandomState` is not completely random.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
