feniljain commented on code in PR #19342:
URL: https://github.com/apache/datafusion/pull/19342#discussion_r2635323310
##########
datafusion/physical-plan/src/async_func.rs:
##########
@@ -221,6 +234,49 @@ impl ExecutionPlan for AsyncFuncExec {
}
}
+struct CoalesceInputStream {
+ input_stream: Pin<Box<dyn RecordBatchStream + Send>>,
+ batch_coalescer: LimitedBatchCoalescer,
+}
+
+impl Stream for CoalesceInputStream {
+ type Item = Result<RecordBatch>;
+
+ fn poll_next(
+ mut self: Pin<&mut Self>,
+ cx: &mut Context<'_>,
+ ) -> Poll<Option<Self::Item>> {
+ let mut completed = false;
+
Review Comment:
It seems this was left as a `TODO` in general
[here](https://github.com/apache/datafusion/blob/91cfb6990319a672195f97d0b2b179fa9634fec9/datafusion/physical-plan/src/async_func.rs#L181)
As all metrics need to be implemented, I think it will be better to do it in
a separate PR? What do you think?
I will take up metrics PR after this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
