feniljain commented on code in PR #19342: URL: https://github.com/apache/datafusion/pull/19342#discussion_r2637243357
########## datafusion/physical-plan/src/async_func.rs: ########## Review Comment: Regarding tests, I see we don't have tests where I have control over stream, which is required to calculate how many times did it get called. And I am not sure how hard would it be create a test with these conditions. I tested this flow earlier by keeping a `DEBUG` log in stream flow of `AsyncFuncExec`, manipulating `target_batch_size` in [this](https://github.com/apache/datafusion/blob/d8e68a404aa7955b4913bab1c658a4ec5c82f0fc/datafusion/core/tests/user_defined/user_defined_async_scalar_functions.rs#L33) test, this helped me confirm everything was working fine. Also I checked other two PRs and none contained tests: - https://github.com/apache/datafusion/pull/19002/ - https://github.com/apache/datafusion/pull/18604 I suspect tests were not added in them for the same reason I mentioned above, do correct me if I am missing a point, thanks! 🙇🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
