andygrove commented on code in PR #2949:
URL: https://github.com/apache/datafusion-comet/pull/2949#discussion_r2637236142
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -111,6 +111,10 @@ object CometConf extends ShimCometConf {
.booleanConf
.createWithDefault(false)
+ // Deprecated: native_comet uses mutable buffers incompatible with Arrow FFI
best practices
+ // and does not support complex types. Use native_iceberg_compat or auto
instead.
+ // See: https://github.com/apache/datafusion-comet/issues/2186
+ @deprecated("Use SCAN_NATIVE_ICEBERG_COMPAT or SCAN_AUTO instead", "0.9.0")
Review Comment:
I think it would be better to suggest using `auto` since that will pick the
best available scan for the specific query. There should be no need to pick
specific scan implementations other than for unit testing.
```suggestion
@deprecated("Use SCAN_AUTO instead", "0.9.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
