Jefffrey commented on code in PR #19439:
URL: https://github.com/apache/datafusion/pull/19439#discussion_r2637846433
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -2718,71 +2721,6 @@ impl ScalarValue {
Ok(array)
}
- fn build_decimal32_array(
Review Comment:
Inlining these
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -1337,6 +1331,7 @@ impl ScalarValue {
/// Returns a [`ScalarValue`] representing PI
pub fn new_pi(datatype: &DataType) -> Result<ScalarValue> {
match datatype {
+ DataType::Float16 => Ok(ScalarValue::from(f16::PI)),
Review Comment:
Adding some missing support for f16 (where possible)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
