Jefffrey commented on code in PR #19439:
URL: https://github.com/apache/datafusion/pull/19439#discussion_r2642379864
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -1346,6 +1341,7 @@ impl ScalarValue {
/// Returns a [`ScalarValue`] representing PI's upper bound
pub fn new_pi_upper(datatype: &DataType) -> Result<ScalarValue> {
match datatype {
+ // TODO: half::f16 doesn't seem to have equivalent
Review Comment:
Raised https://github.com/apache/datafusion/issues/19465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
