Jefffrey commented on code in PR #19341:
URL: https://github.com/apache/datafusion/pull/19341#discussion_r2638734239
##########
datafusion/functions/src/datetime/date_bin.rs:
##########
@@ -146,7 +162,44 @@ impl DateBinFunc {
DataType::Interval(DayTime),
Timestamp(array_type, Some(TIMEZONE_WILDCARD.into())),
]),
- ]
+ ];
+
+ match array_type {
+ Second | Millisecond => {
+ v.append(&mut vec![
+ Exact(vec![
+ DataType::Interval(MonthDayNano),
+ Time32(array_type),
+ Time32(array_type),
Review Comment:
I was more thinking of trying to simplify the signature (which looks a bit
gnarly) and potentially the implementation too. In terms of actual
functionality it should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
