Jefffrey commented on code in PR #19449:
URL: https://github.com/apache/datafusion/pull/19449#discussion_r2638955001
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -888,8 +900,43 @@ fn get_data_types(native_type: &NativeType) ->
Vec<DataType> {
NativeType::String => {
vec![DataType::Utf8, DataType::LargeUtf8, DataType::Utf8View]
}
- // TODO: support other native types
- _ => vec![],
+ NativeType::Decimal(_, _) => todo!(),
+ NativeType::Timestamp(time_unit, timezone) => {
+ vec![DataType::Timestamp(*time_unit, timezone.to_owned())]
+ }
+ NativeType::Time(TimeUnit::Second) =>
vec![DataType::Time32(TimeUnit::Second)],
+ NativeType::Time(TimeUnit::Millisecond) => {
+ vec![DataType::Time32(TimeUnit::Millisecond)]
+ }
+ NativeType::Time(TimeUnit::Microsecond) => {
+ vec![DataType::Time64(TimeUnit::Microsecond)]
+ }
+ NativeType::Time(TimeUnit::Nanosecond) => {
+ vec![DataType::Time64(TimeUnit::Nanosecond)]
+ }
+ NativeType::Duration(time_unit) =>
vec![DataType::Duration(*time_unit)],
+ NativeType::Interval(interval_unit) =>
vec![DataType::Interval(*interval_unit)],
+ NativeType::FixedSizeBinary(size) =>
vec![DataType::FixedSizeBinary(*size)],
+ NativeType::FixedSizeList(logical_field, size) => {
+ get_data_types(logical_field.logical_type.native())
+ .iter()
+ .map(|child_dt| {
+ let field = Field::new(
+ logical_field.name.clone(),
+ child_dt.clone(),
+ logical_field.nullable,
+ );
+ DataType::FixedSizeList(Arc::new(field), *size)
+ })
+ .collect()
+ }
+ // TODO: implement for nested types
Review Comment:
These are a bit funky to implement so left as TODO for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
