LucaCappelletti94 commented on PR #2077: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2077#issuecomment-3681702397
This refactor is mostly motivated by two reasons: improved code cleanliness, and ideally, reduced memory footprint and time requirements. Regarding code cleanliness, it removes certain code complexity from the parser but increases complexity in the tokenizer, so the benefit is unclear. I proceeded to measure the time requirements in the largest SQL documents I have, and there is no significant change in performance between main and this branch. I have not measured changes in memory footprint yet, but given the lack of clear benefit in the aforementioned points, I would proceed to close the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
