Jefffrey commented on code in PR #19442:
URL: https://github.com/apache/datafusion/pull/19442#discussion_r2639628544
##########
datafusion/functions/src/datetime/to_unixtime.rs:
##########
@@ -68,7 +67,7 @@ impl Default for ToUnixtimeFunc {
impl ToUnixtimeFunc {
pub fn new() -> Self {
Self {
- signature: Signature::variadic_any(Volatility::Immutable),
+ signature: Signature::user_defined(Volatility::Immutable),
Review Comment:
This wasn't the direction I had in mind for refactoring; in general we
should avoid using user_defined.
I think the previous state of the PR was in a better condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
