Omega359 commented on code in PR #19442:
URL: https://github.com/apache/datafusion/pull/19442#discussion_r2641442621
##########
datafusion/functions/src/datetime/to_unixtime.rs:
##########
@@ -27,7 +27,7 @@ use std::any::Any;
#[user_doc(
doc_section(label = "Time and Date Functions"),
- description = "Converts a value to seconds since the unix epoch
(`1970-01-01T00:00:00Z`). Supports strings, dates, timestamps and double types
as input. Strings are parsed as RFC3339 (e.g. '2023-07-20T05:44:00') if no
[Chrono
formats](https://docs.rs/chrono/latest/chrono/format/strftime/index.html) are
provided.",
+ description = "Converts a value to seconds since the unix epoch
(`1970-01-01T00:00:00Z`). Supports strings, dates, timestamps, integer,
unsigned integer, and float types as input. Strings are parsed as RFC3339 (e.g.
'2023-07-20T05:44:00') if no [Chrono
formats](https://docs.rs/chrono/latest/chrono/format/strftime/index.html) are
provided. Integers, unsigned integers, and floats are interpreted as seconds
since the unix epoch (`1970-01-01T00:00:00Z`).",
Review Comment:
```suggestion
description = "Converts a value to seconds since the unix epoch
(`1970-01-01T00:00:00`). Supports strings, dates, timestamps, and numeric types
as input. Strings are parsed as RFC3339 (e.g. '2023-07-20T05:44:00') if no
[Chrono
formats](https://docs.rs/chrono/latest/chrono/format/strftime/index.html) are
provided. Numerics are interpreted as seconds since the unix epoch
(`1970-01-01T00:00:00`).",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
