BlakeOrth commented on PR #19366: URL: https://github.com/apache/datafusion/pull/19366#issuecomment-3683032721
I think these benchmark results are generally in line with my expectations for a benchmark running against local files. Some meaningful improvement on queries that already run quickly (single milliseconds range) and generally no change on anything where file access, which are already pretty fast, is an overall small proportion of the work that needs to be done. It looks like most of the reported slow downs are on the long-running queries. I can't really imagine this work having any meaningful effect on those queries; Considering file listing happens at the beginning of the query processing I'm inclined to say that may be run-to-run variation more than this work actually slowing things down. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
